E2E: Improve multiple block moving test stability #47423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WunderBart
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
Mamaduka
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
The logic behind changes makes sense to me. Thank you, @WunderBart!
|
Flaky tests detected in 804eb94. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4007267833
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The flakiness of these tests has increased after enabling the concurrent mode in #46467. Let's improve the stability by waiting for the UI to catch up.
Context: #47173 (comment)
How?
The UI sometimes doesn't catch up with the keyboard strokes that select multiple blocks. This causes the multiple block moving tests to sometimes move just one block. To address that, we need to wait until the blocks are in the "Multiple selected blocks" state before moving them.
Testing Instructions
This can be tested locally via the following: